-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export type to support isolatedModules #8585
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 53a60ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the PR. Change seems straightforward and non-breaking
. Can you
- Add a
minor
changeset. Learn more here export type to support isolatedModules #8585 (comment) - add a test for this
Sorry for the delay in review
@cungminh2710 Is there any progress on this? |
@dzearing hi there, i forgot to work on this. Will address some feedback soon this week |
@saihaj it's been a while. any chance to land this PR? |
Description
Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'
Related # (issue)
Close #6773
Type of change
Checklist: