Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export type to support isolatedModules #8585

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cungminh2710
Copy link

@cungminh2710 cungminh2710 commented Nov 8, 2022

Description

Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'

Related # (issue)

Close #6773

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 53a60ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR. Change seems straightforward and non-breaking. Can you

  1. Add a minor changeset. Learn more here export type to support isolatedModules #8585 (comment)
  2. add a test for this

Sorry for the delay in review

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Jan 18, 2023
@dzearing
Copy link

dzearing commented Oct 31, 2023

@cungminh2710 Is there any progress on this?

@cungminh2710
Copy link
Author

@dzearing hi there, i forgot to work on this. Will address some feedback soon this week

@cungminh2710 cungminh2710 requested a review from saihaj November 19, 2023 23:31
@cungminh2710
Copy link
Author

@saihaj it's been a while. any chance to land this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-answer Waiting for answer from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-exporting when using isolatedModules
3 participants