Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable callback to negotiate NTLM or Kerberos #2248

Closed
wants to merge 7 commits into from

Conversation

twsouthwick
Copy link
Member

No description provided.

{
cts.CancelAfter((int)_timeout.MillisecondsRemaining);
}
using CancellationTokenSource cts = CreateCancellationTokenSource();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use curly braces for clarity rather than implicily scoped using.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (416afcd) 72.45% compared to head (03e5581) 76.67%.
Report is 2 commits behind head on main.

❗ Current head 03e5581 differs from pull request most recent head 714bf3f. Consider uploading reports for the commit 714bf3f to get more accurate results

Files Patch % Lines
...ent/src/Microsoft/Data/SqlClient/TdsParser.SSPI.cs 0.00% 19 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 40.00% 6 Missing ⚠️
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs 33.33% 4 Missing ⚠️
...c/Microsoft/Data/SqlClient/SqlConnectionPoolKey.cs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   72.45%   76.67%   +4.21%     
==========================================
  Files         309      247      -62     
  Lines       61960    38819   -23141     
==========================================
- Hits        44895    29764   -15131     
+ Misses      17065     9055    -8010     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.54% <40.00%> (-0.16%) ⬇️
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twsouthwick
Copy link
Member Author

Thanks @Wraith2 for the comments - I expect this PR to change drastically before I'm fully ready for review. I'm planning on using this to generate the builds so I can have some customers I'm working with try it out for their use cases to verify things

@twsouthwick
Copy link
Member Author

Closing for now until decisions are made in #2253

@twsouthwick twsouthwick closed this Dec 1, 2023
@twsouthwick twsouthwick deleted the ntlm-callback branch January 23, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants