-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable callback to negotiate NTLM or Kerberos #2248
Conversation
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
{ | ||
cts.CancelAfter((int)_timeout.MillisecondsRemaining); | ||
} | ||
using CancellationTokenSource cts = CreateCancellationTokenSource(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use curly braces for clarity rather than implicily scoped using.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 72.45% 76.67% +4.21%
==========================================
Files 309 247 -62
Lines 61960 38819 -23141
==========================================
- Hits 44895 29764 -15131
+ Misses 17065 9055 -8010
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @Wraith2 for the comments - I expect this PR to change drastically before I'm fully ready for review. I'm planning on using this to generate the builds so I can have some customers I'm working with try it out for their use cases to verify things |
Closing for now until decisions are made in #2253 |
No description provided.