-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines | Fix dotnet Installation on ARM64 #3175
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Replace remaining CI usages of UseDotNet with ensure-dotnet-version
echo "version= $version" | ||
|
||
# Install dotnet ########################################### | ||
Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile "dotnet-install.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this will end up becoming a blocker for onebranch conversion... we can cross that bridge when we get to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, uhm ... maybe. I'll have to dig through the network restrictions list again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leverage 1es artifact instead? this one: https://dev.azure.com/devdiv/XlabImageFactory/_git/XlabImageFactory?path=/artifacts/windows-dotnetcore-sdk/dotnet-install.ps1 supports fetching all SDK variants and handles arm64 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetching anything external (assuming "dot.net" is considered external) from an official OB pipeline will not fly. But if it's just a test pipeline, might be okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try that, though it's not a publicly accessible ADO instance.
/azp run |
Azure Pipelines failed to run 2 pipeline(s). |
Instead of this PR, you can install Dotnet SDK on Windows via artifact registry, that is more reliable way of installing Dotnet SDK. We do the same on Linux, and can be done on Windows too.. you need not call UseDotnetSDK in that case. |
@cheenamalhotra you're going to have to explain that one a bit more. I don't see in our existing pipelines where we're doing anything other than UseDotNet task. |
/azp run |
Azure Pipelines failed to run 2 pipeline(s). |
/azp run |
Azure Pipelines failed to run 2 pipeline(s). |
Discussed internally. |
…uld be running on windows.
This is a recreation of #3037 to make it easier to trigger CI builds. The original PR description follows:
Looks like there's a bug in the UseDotNet Azure DevOps functionality and it installs x86 .NET on ARM:
microsoft/azure-pipelines-tasks#20300
Adding an install script to resolve this and install the proper version on ARM.
Also, the steps were added twice as prebuild and build. Removed one.
Here you can find the logs showing the x86 install:
https://dev.azure.com/sqlclientdrivers/public/_build/results?buildId=102454&view=logs&j=f62ec789-9893-5f91-3293-e8a10244adaa&t=83eb4f36-b8e6-57c5-1c44-e749ef0d4796