Skip to content

[v7.0.3] Backport Localization Changes - #4634

Open
benrr101 wants to merge 1 commit into
release/7.0from
dev/russellben/703-backport-localization
Open

[v7.0.3] Backport Localization Changes#4634
benrr101 wants to merge 1 commit into
release/7.0from
dev/russellben/703-backport-localization

Conversation

@benrr101

@benrr101 benrr101 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Backports applicable localization updates from main to the release/7.0 branch.

Changes

  • Added localized resources for:
    • SQL_ServerCertificateFileLoadFailed
    • SQL_ServerCertificateNotAvailable
  • Updated VerifyEnclaveKeyBindingFailed localized resources, replacing the English fallback text in localized .resx files.
  • Skipped main-only resource keys that are not referenced by the release/7.0 branch.
  • Confirmed the AKV provider resource file has no content changes to backport.

Validation

  • Ran git diff --check
  • Parsed all modified .resx files successfully

@benrr101 benrr101 added this to the 7.0.3 milestone Sep 2, 2026
@benrr101
benrr101 requested review from a team and a balanced review from Copilot September 2, 2026 19:26
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Sep 2, 2026
@benrr101
benrr101 changed the base branch from main to release/7.0 September 2, 2026 19:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Turkish and Italian resources contain user-visible translation and punctuation errors.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Backports applicable localization updates to the release/7.0 resource set.

Changes:

  • Localizes two server-certificate errors.
  • Replaces English fallback text for enclave key-binding failures.
File summaries
File Description
Strings.zh-Hant.resx Traditional Chinese resources
Strings.zh-Hans.resx Simplified Chinese resources
Strings.tr.resx Turkish resources
Strings.ru.resx Russian resources
Strings.pt-BR.resx Brazilian Portuguese resources
Strings.pl.resx Polish resources
Strings.ko.resx Korean resources
Strings.ja.resx Japanese resources
Strings.it.resx Italian resources
Strings.fr.resx French resources
Strings.es.resx Spanish resources
Strings.de.resx German resources
Strings.cs.resx Czech resources
Review details
  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx
Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.tr.resx
@benrr101

benrr101 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@priyankatiwari08 priyankatiwari08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One non-blocking nit inline: the pt-BR entries use doubled single quotes (''ServerCertificate'', ''{0}'') that string.Format will not collapse, so they render literally. Inherited from main, so better fixed upstream than in this backport.

Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.pt-BR.resx
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.67%. Comparing base (40c7841) to head (7b68812).
⚠️ Report is 5 commits behind head on release/7.0.

❗ There is a different number of reports uploaded between BASE (40c7841) and HEAD (7b68812). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (40c7841) HEAD (7b68812)
CI-SqlClient 1 0
Additional details and impacted files
@@               Coverage Diff               @@
##           release/7.0    #4634      +/-   ##
===============================================
- Coverage        72.72%   66.67%   -6.06%     
===============================================
  Files              280      275       -5     
  Lines            43373    67954   +24581     
===============================================
+ Hits             31544    45307   +13763     
- Misses           11829    22647   +10818     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 66.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

4 participants