[tests] restore ignored tests from .NET 10 issues #9744
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Feb 3, 2025
|
It doesn't look like the MSBuild bug is fixed with Let me rebase this after the next .NET SDK bump. |
|
Yeah, in the diff: I don't see this one yet: |
Context: dotnet/roslyn-analyzers#7525 Context: dotnet/msbuild#11237 The two above issues are fixed, so we can restore the impacted tests by partially reverting 37014d1.
jonathanpeppers
force-pushed
the
dev/peppers/restoretests
branch
from
a55c688 to
8d35027
Compare
jonathanpeppers
commented
Feb 13, 2025
| // FIXME: https://github.com/dotnet/msbuild/issues/11237, removed `(` and `)` characters | ||
| using (var b = CreateApkBuilder (Path.Combine ("temp", $"BuildProguard Enabled1{rid}"))) { | ||
| using (var b = CreateApkBuilder (Path.Combine ("temp", $"BuildProguard Enabled(1){rid}"))) { |
There was a problem hiding this comment.
It appears the MSBuild fix is working:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/roslyn-analyzers#7525
Context: dotnet/msbuild#11237
The two above issues are fixed, so we can restore the impacted tests by partially reverting 37014d1.