Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude _.pdb files from BinSkim scan. #13916

Merged

Conversation

andriipatsula
Copy link
Member

Certain PDBs causing Binskim to behave unexpectedly and crash with Out of memory exception. dotnet/arcade-services#2744

To double check:

@andriipatsula
Copy link
Member Author

@MilenaHristova
Copy link
Contributor

Is this excluding all pdb files?

@andriipatsula
Copy link
Member Author

Is this excluding all pdb files?

Nope, just _.pdb files

@andriipatsula
Copy link
Member Author

andriipatsula commented Jul 20, 2023

Is this excluding all pdb files?

Nope, just _.pdb files

concreate example: runtime.linux-arm.Microsoft.NETCore.ILDAsm runtime.linux-arm.Microsoft.NETCore.ILDAsm 7.0.10-servicing.23363.10 \runtimes\linux-arm\native\_.pdb

@MilenaHristova
Copy link
Contributor

MilenaHristova commented Jul 20, 2023

Is this excluding all pdb files?

Nope, just _.pdb files

concreate example: runtime.linux-arm.Microsoft.NETCore.ILDAsm runtime.linux-arm.Microsoft.NETCore.ILDAsm 7.0.10-servicing.23363.10 \runtimes\linux-arm\native\_.pdb

I see, thanks

@andriipatsula andriipatsula merged commit b243c89 into dotnet:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants