Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable signing validation of .pkg files using SignCheck #15489

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 6, 2025

@ellahathaway
Copy link
Member Author

ellahathaway commented Feb 7, 2025

Current output from test run is:

[File] test.pkg, Signed: True [Error] Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/1/2027 10:12:15 PM to 2/1/2027 10:12:15 PM)., Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/1/2027 10:12:15 PM to 2/1/2027 10:12:15 PM)., Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/9/2035 9:40:36 PM to 2/9/2035 9:40:36 PM).
  [File] 6741a098e863e0ff41f9bddf2c67747dbd9adde100e3deca6e308852287baddd.pkg, Signed: False, Virtual path: test.pkg/NestedPkg.pkg, Full Name: NestedPkg.pkg [Error] Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/1/2027 10:12:15 PM to 2/1/2027 10:12:15 PM)., Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/1/2027 10:12:15 PM to 2/1/2027 10:12:15 PM)., Timestamp (2/7/2025 6:54:02 PM) outside validity period (2/9/2035 9:40:36 PM to 2/9/2035 9:40:36 PM).

Need to figure out two things:

  • Why the timestamp is outside of the validity period - fixed
  • Why the NestedPkg.pkg is listed as being not-signed. - pinged @mmitche offline. I don't think that the lack of pkg signature here is related to these code changes, so I'm going to publish this PR now.

@ellahathaway
Copy link
Member Author

ellahathaway commented Feb 11, 2025

Converting this to a draft PR. There are a few things to do first that will clean up the logic in this PR:

  • Refactor the ArchiveVerifier. This will allow other package types to inherit the classes in a more concise way.
  • Break the MacOsPkg tool up into a cli tool and a library

@ellahathaway ellahathaway marked this pull request as draft February 11, 2025 23:51
@ellahathaway
Copy link
Member Author

This PR is ready. Just wanting on #15519 and #15508 to be completed before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable signing validation of .pkg files using SignCheck
2 participants