Introduce PDB artifact kind #15497
Merged
Introduce PDB artifact kind #15497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the PDB artifact kind, which replaces the Publish.proj copying of PDBs to the PDBArtifacts build storage. In addition, the following refactoring was done - Kind is now required on all ItemsToPushToBlobFeed. - Do not handle symbols.nupkgs specially in the manifest generation. Instead, they are just normal blobs - Publish.proj has been updated to ensure that Kind is set properly given legacy properties (PublishFlatContainer), or for artifacts like symbol nupkgs. - Refactor the artifact types so that they have a common base class for many properties.
|
Still need the publishing side of things to go in before this will work. |
|
Actually...may not need the publishing side at all. |
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PushToBuildStorageTests.cs
Outdated
Show resolved
Hide resolved
NikolaMilosavljevic
previously approved these changes
Feb 13, 2025
NikolaMilosavljevic
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the PDB artifact kind, which replaces the Publish.proj copying of PDBs to the PDBArtifacts build storage. In addition, the following refactoring was done
To double check: