Add support for TypeConverter #10730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
src/Components/Components/src/EventCallbackFactoryBinderExtensions.cs
Outdated
Show resolved
Hide resolved
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
rynowak
commented
Jun 1, 2019
Sadly, it's not that simple. See: #9386 which tracks all of the work in this area. InvariantCulture will result in the correct behavior for an This PR doesn't cover fixing that issue, and as far as I know just makes the current behavior more clearly explicit. We definitely plan to address this before release. |
src/Components/Components/src/EventCallbackFactoryBinderExtensions.cs
Outdated
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Jun 3, 2019
|
Sadly we're out of time, this isn't going to make it for preview 6. |
rynowak
force-pushed
the
rynowak/converters
branch
from
db88626 to
c47c4fb
Compare
Fixes: #8493 Fixes: #9632 Fixes: #9339 Fixes: #8385 Fixes: 10077 This fix adds support for type converters as well as a few other minor things we were missing from binding. The key thing about supporting conversions is that we new can support arbitrary types with `@bind`. This means you can use it with generics, which is something many users have tried. Along with type converters we get Guid and TimeSpan from the BCL. The BCL also includes converters for types we're less interested in like `short`.
rynowak
force-pushed
the
rynowak/converters
branch
from
c47c4fb to
9f3ca70
Compare
ghost
deleted the
This was referenced Jun 5, 2019
Closed
4 tasks
kzu
added a commit
to kzu/aspnetcore
that referenced
this pull request
Apr 15, 2023
It's quite convenient to be able to bind directly to data containing raw HTML. This is quite convoluted to do today, requiring registering a TypeDescriptionProvider, which in turn returns a custom type descriptor which in turn can provide the missing TypeConverter for the desired type. This adds support out of the box for binding straight to markup strings. Follows the implementation and tests from dotnet#10730. Closes dotnet#47718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9632
Fixes: #8385
Fixes: #10077
This fix adds support for type converters as well as a few other minor
things we were missing from binding. The key thing about supporting
conversions is that we new can support arbitrary types with
@bind.This means you can use it with generics, which is something many users
have tried.
Along with type converters we get Guid and TimeSpan from the BCL. The
BCL also includes converters for types we're less interested in like
short.Note: this change is targeting preview 7.