-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Implemented minimal WebTransport Middleware #41945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented minimal WebTransport Middleware #41945
Conversation
What does the WebTransport API look like? Is there a new API we're adding here? What does this middleware do? |
3ddf9eb
to
586ccc8
Compare
Just squashed the commits to get a nicer permalink for my other PR (#41949). No code changes were made. |
…genkin/WebTransportMiddleware
…I. This API will change and is just a placeholder
Those are great questions! I don't know yet as I am doing everything very incrementally. My next follow up PR will hopefully answer these questions. This PR just sets up the project. |
The theory is that it will work similar to WebSockets, there will be a new Feature that you can call Accept on and get back a WebTransport abstraction. We don't know the shape of that yet, but it may mirror the client side JS APIs. |
Is it similar enough to consider putting the WebTransport middleware in the |
I would only do that if we expected them to share any code. I don't think that will be the case. |
So in theory when we ship this would it go into the BCL networking APIs? |
Only the symmetrical parts (if any), similar to the WebSocket type. |
Yes, like the entire WebSocket implementation 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After yesterday's design discussion it looks like most of the WebTransport functionality will need to be built directly into Kestrel. Let's pause this PR until we're sure if we need the middleware package or not.
I agree. By "pause", do you mean close or just stop committing to it? |
How about you close the PR but keep the branch in case we need it later. |
Quick PR to add a new project for the WebTransport Middleware. This will eventually host the WebTransport API.
TODO