Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates][Identity] Update jquery-validation to 1.20.0 #60148

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2025

Updates the jquery-validation scripts to 1.20.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 1, 2025
@RussKie RussKie enabled auto-merge (squash) February 4, 2025 03:04
@RussKie
Copy link
Member

RussKie commented Feb 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@radical
Copy link
Member

radical commented Feb 11, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sebastienros
Copy link
Member

sebastienros commented Feb 13, 2025

@javiercn do you know if that's a valid PR? It's downgrading a version, and the tests are failing because of that:

2025-02-12T22:03:08.0308855Z [xUnit.net 00:00:10.77]     Microsoft.AspNetCore.Identity.Test.IdentityUIScriptsTest.IdentityUI_ScriptTags_FallbackSourceContent_Matches_CDNContent(scriptTag: https://cdnjs.cloudflare.com/ajax/libs/jquery-validate/1.21.0/jquery.validate.min.js) [FAIL]
2025-02-12T22:03:08.0475613Z [xUnit.net 00:00:10.78]       Assert.Equal() Failure: Strings differ
2025-02-12T22:03:08.0475980Z [xUnit.net 00:00:10.78]                                         ↓ (pos 35)
2025-02-12T22:03:08.0476036Z [xUnit.net 00:00:10.78]       Expected: ···"dation Plugin - v1.21.0 - 7/17/2024 * htt"···
2025-02-12T22:03:08.0476250Z [xUnit.net 00:00:10.78]       Actual:   ···"dation Plugin - v1.20.0 - 10/10/2023 * ht"···
2025-02-12T22:03:08.0476296Z [xUnit.net 00:00:10.78]                                         ↑ (pos 35)

Update: Apparently you made the change, so I bet it's intentional, can you fix the tests ?

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 20, 2025
@SteveSandersonMS
Copy link
Member

@javiercn Could you give a comment on @sebastienros's question above?

Or if we don't really need to downgrade this package, can we close this?

@javiercn javiercn closed this Feb 27, 2025
auto-merge was automatically disabled February 27, 2025 10:48

Pull request was closed

@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants