OutputCaching: Avoid locking request with invalid cache key when another request is in-flight - #68629
Merged
Merged
Conversation
…her request is in-flight
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a security-sensitive concurrency issue in OutputCaching where requests with an invalid/empty cache key could still participate in response locking, causing unrelated in-flight responses to be coalesced under the empty dispatcher key.
Changes:
- Skip response locking when
CacheKeyis null/empty to prevent invalid-key coalescing. - Add a regression test to ensure concurrent requests with an invalid key execute independently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Middleware/OutputCaching/src/OutputCacheMiddleware.cs | Prevents scheduling response-locking work under an invalid/empty cache key. |
| src/Middleware/OutputCaching/test/OutputCacheMiddlewareTests.cs | Adds a concurrent regression test covering invalid-key locking behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
rokonec
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67763
Previously, an invalid cache key (surfaced as string.Empty) would let two concurrent requests to serve the same response (
var cacheEntry = await _requestDispatcher.ScheduleAsync(context.CacheKey, key => ExecuteResponseAsync());)We shouldn't call ScheduleAsync with empty CacheKey.