Skip to content

Don't trim trailing whitespace in resx files - #68634

Merged
Youssef1313 merged 1 commit into
mainfrom
dev/ygerges/resx-trim
Aug 19, 2026
Merged

Don't trim trailing whitespace in resx files#68634
Youssef1313 merged 1 commit into
mainfrom
dev/ygerges/resx-trim

Conversation

@Youssef1313

Copy link
Copy Markdown
Member

The RESX generator in Visual Studio produces extra trailing whitespaces in resx files. Manual edits to the resx files could lead editors to try to trim these whitespaces, then a next developer editing resx by Visual Studio will get those whitespaces back again, etc.
It's best to instruct editors to not touch the whitespaces in this case.

Copilot AI lite review requested due to automatic review settings August 19, 2026 07:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository-wide EditorConfig settings to prevent editors from trimming trailing whitespace in .resx files, avoiding noisy whitespace churn caused by Visual Studio’s RESX generator behavior.

Changes:

  • Adds a .resx-specific EditorConfig section to disable trim_trailing_whitespace.
  • Fixes the formatting/line-numbering at the end of .editorconfig (no semantic change).

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@Youssef1313 Youssef1313 added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 19, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@Youssef1313
Youssef1313 merged commit bda7089 into main Aug 19, 2026
35 checks passed
@Youssef1313
Youssef1313 deleted the dev/ygerges/resx-trim branch August 19, 2026 10:19
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants