Separate tasks in our workflows #1269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the initial code to create a check run using a chained workflow.
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
jskeet
approved these changes
Mar 11, 2025
| @@ -61,7 +61,7 @@ static async Task<int> Main(string owner, string repo, bool dryrun =false) | |||
| { | |||
| if ((token is not null) && (headSha is not null)) | |||
| { | |||
| await logger.BuildCheckRunResult(token, owner, repo, headSha); | |||
| var annotations = await logger.BuildCheckRunResult(token, owner, repo, headSha); | |||
There was a problem hiding this comment.
Revert this change, as it appears to be unused? (Or emit the annotations somewhere?)
| await core.GroupAsync("Writing run outputs", async () => | ||
| { | ||
| await core.SetOutputAsync("check_name", title, JsonCheckRunAnnotationSerializerContext.Default.String); | ||
|
|
There was a problem hiding this comment.
Maybe group these into pairs of lines (so remove the blank line between the two check_name-related lines, and then between the two conclusion-related lines, etc.)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task that writes statuses requires different rights than the task that executes the tools. So, separate these into separate tasks.
Replace #1257 (This initial version can't be run from a fork).