-
Notifications
You must be signed in to change notification settings - Fork 89
allow unsafe
and ref
in grammar
#943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`unsafe` and ref returns are allowed for delegates, local functions, and methods. Update the grammar for that part. Fixes dotnet#886 See dotnet#941 (review)
This change from dotnet#941 should be made in 7.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works, but @Nigel-Ecma may well have a nicer way of representing it. It would be nice to avoid all the branching - if we had a rule of "return_type or ref_kind + ref_return_type" then we could remove some duplication. We'd need to explicitly prohibit async ref local functions (rather than doing it in the grammar) but this wouldn't be the first time we did that sort of thing.
Will the grammar summary be updated automatically after this is merged? |
I'll take a look but not before the meeting… |
Yes :-) |
unsafe
and ref returns are allowed for delegates, local functions, and methods. Update the grammar for that part.Fixes #886
See #941 (review)