-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Globalization.CompareOptions update #10087
Conversation
StringSort example updated with note about changes in .NET 5 and later versions. Now uses more modern and idiomatic C# language features, and correct formatting.
New CompareOptions example showing each option.
F# example showing usage of each CompareOptions value.
Rewritten. Uses more modern language constructs. Includes note about differences between .NET 5+ and earlier versions.
Rewritten with more modern .NET language usage, and note about difference between .NET 5+ and prior versions with regard to sort order.
New C++ example showing the effect of each of the CompareOptions values.
New VB example showing the effect of each of the CompareOptions values.
…s/VB/compareoptions_values.vb Remove misplaced file.
New VB example showing the effect of each of the CompareOptions values.
Updated descriptions for each of the options. New introduction, including notes about the StringSort and ligature character changes in .NET 5. Links added to updated and new example code for all supported languages.
@dotnet-policy-service agree |
This comment was marked as outdated.
This comment was marked as outdated.
Tagging subscribers to this area: @dotnet/area-system-globalization |
@daverayment Thanks for submitting the PR! Would you be able to fix the errors here: https://github.com/dotnet/dotnet-api-docs/actions/runs/9810025035/job/27168649470?pr=10087? I don't believe your changes caused them, but since we're already modifying the code, it would be great to address them. Also, did you run the updated samples to ensure everything works correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo the minor comment and fixing the CI failures, LGTM!
@daverayment would you have a chance to address the minor remaining feedback so we can proceed merging this one? |
@tarekgh Thank you for the review. I'm sorry, I don't have time to revisit this at the moment. I don't know how to add the parent project, so perhaps you could help? |
This comment was marked as outdated.
This comment was marked as outdated.
@gewarren do you know who can help guide how we can fix the issues with this PR? |
CC @BillWagner if can help too. |
This reverts commit 853b27b.
Summary
CompareOptions
enum values affect string comparisons, for all four supported languages.StringSort
code example, which now uses more modern and consistent .NET conventions, and includes a note about changes brought about in .NET 5 (whereStringSort
andNone
are now equivalent by default).StringSort
F# example.Additional Globalization documentation update in main dotnet/docs repo PR: 41661
Fixes #41052