Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.ComponentModel #10965

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

System.ComponentModel #10965

wants to merge 13 commits into from

Conversation

DickBaker
Copy link
Contributor

suggested changes to 84 projects per Issue #10961

@DickBaker DickBaker requested a review from a team as a code owner February 15, 2025 10:00
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 15, 2025
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
Dick Baker added 3 commits February 15, 2025 15:15
slightly reverted AmbientValueAttribute\Overview\attributesdemocontro…
fbb9c12 
…l.cs so that Designer can work

BTW I also edited Issue dotnet#10961 to include this Designer failure
slightly reverted AmbientValueAttribute\Overview\attributesdemocontro…
957c16c 
…l.cs so that Designer can work

BTW I also edited Issue dotnet#10961 to include this Designer failure
Merge branch 'main' of https://github.com/DickBaker/dotnet-api-docs
c2984f5
@DickBaker DickBaker mentioned this pull request Feb 14, 2025
Open
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@ericstj ericstj requested review from gewarren and a team March 31, 2025 17:57
gewarren
gewarren reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these improvements @DickBaker! I will respond to my comments so you don't have to.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 5f2c872:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.ComponentModel/DefaultValueAttribute.xml ⚠️Warning View Details
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/attributesdemocontrol.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/form1.cs ✅Succeeded
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AsyncCompletedEventArgs/Overview/primenumbercalculatormain.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AsyncCompletedEventArgs/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/.ctor/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/Count/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/Count/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/GetEnumerator/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/GetEnumerator/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/Overview/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/IsBusy/Form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/IsBusy/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/backgroundworkersimple.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/fibonacciform.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/program.cs ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/ReportProgress/form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/ReportProgress/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Bindable/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Overview/source.cs ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.ComponentModel/DefaultValueAttribute.xml

  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit f08803e:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/attributesdemocontrol.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/form1.cs ✅Succeeded
snippets/csharp/System.ComponentModel/AmbientValueAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AsyncCompletedEventArgs/Overview/primenumbercalculatormain.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AsyncCompletedEventArgs/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/.ctor/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/Count/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/Count/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/GetEnumerator/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/GetEnumerator/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/AttributeCollection/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/AttributeCollection/Overview/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/IsBusy/Form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/IsBusy/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/backgroundworkersimple.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/fibonacciform.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/Overview/program.cs ✅Succeeded
snippets/csharp/System.ComponentModel/BackgroundWorker/ReportProgress/form1.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BackgroundWorker/ReportProgress/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Bindable/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.ComponentModel/BindableAttribute/Overview/source.cs ✅Succeeded View
snippets/csharp/System.ComponentModel/BindingListT/FindCore/Form1.cs ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DickBaker @gewarren