Skip to content

Remove bad crefs from deprecated package #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

gewarren
Copy link
Contributor

No description provided.

@gewarren gewarren requested a review from a team as a code owner May 13, 2025 01:21
Copy link
Contributor

@@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

@gewarren gewarren requested a review from a team May 13, 2025 15:47
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I'm assuming you know better than the bot that issued the warning regarding the /// comments in the source.

@gewarren
Copy link
Contributor Author

I'm assuming you know better than the bot that issued the warning regarding the /// comments in the source.

Yes, with this fix, the docs shouldn't get imported from the source anymore.

@gewarren gewarren merged commit 70d1a85 into dotnet:main May 14, 2025
6 checks passed
@gewarren gewarren deleted the socket-handling branch May 14, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants