some better debug-mode parse diagnostics on syntax error #10707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked with @auduchinok today to discuss how to improve parser error recovery
This adds a debug-mode test flag to show the parser stack on parse failure, for use when debugging parser rules
parser stack:
Also rejigs the internal-use-only flag
--ast
to show the ast even if parsing has failed, so we can inspect the nodes producedTypical output of
--test:ShowParserStackOnParseError
is as follows. The information is limited but actually very useful to understand what's going on. fsprojects/FsLexYacc#138 covers actually printing the full rules but needs an FsLex updateWhat this shows is that at the point where the syntax error happens, one of four
unionCaseReprElements
parser rules is still active (this is after anOF
token). We got to this state by the states shown from the bottom up (only 12 are shown). That is we were parsing one of these:then tokens arrived that pushed the various further states involving rules for
unionTypeRepr
andattrUnionCaseDecls
andunionCaseReprElements
on to the stack.