Hide much of Microsoft.ML.Model namespace. (#2649)

TomFinley · web-flow · commit a1b66ac4264f · 2019-02-20T15:14:40.000-08:00
* Internalize ModelLoadContext
* Internalize VersionInfo
* Internalize members of ModelSaveContext while keeping the class itself public
* Internalize Repository and subclasses
diff --git a/src/Microsoft.ML.Core/Data/ModelHeader.cs b/src/Microsoft.ML.Core/Data/ModelHeader.cs
@@ -621,7 +621,8 @@ public static string GetLoaderSigAlt(ref ModelHeader header)
     /// This is used to simplify version checking boiler-plate code. It is an optional
     /// utility type.
     /// </summary>
-    public readonly struct VersionInfo
+    [BestFriend]
+    internal readonly struct VersionInfo
     {
         public readonly ulong ModelSignature;
         public readonly uint VerWrittenCur;
diff --git a/src/Microsoft.ML.Core/Data/ModelLoadContext.cs b/src/Microsoft.ML.Core/Data/ModelLoadContext.cs
@@ -15,7 +15,8 @@ namespace Microsoft.ML.Model
     /// amount of boiler plate code. It can also be used when loading from a single stream,
     /// for implementors of ICanSaveInBinaryFormat.
     /// </summary>
-    public sealed partial class ModelLoadContext : IDisposable
+    [BestFriend]
+    internal sealed partial class ModelLoadContext : IDisposable
     {
         /// <summary>
         /// When in repository mode, this is the repository we're reading from. It is null when
diff --git a/src/Microsoft.ML.Core/Data/ModelLoading.cs b/src/Microsoft.ML.Core/Data/ModelLoading.cs
@@ -16,7 +16,7 @@ namespace Microsoft.ML.Model
     [BestFriend]
     internal delegate void SignatureLoadModel(ModelLoadContext ctx);
 
-    public sealed partial class ModelLoadContext : IDisposable
+    internal sealed partial class ModelLoadContext : IDisposable
     {
         public const string ModelStreamName = "Model.key";
         internal const string NameBinary = "Model.bin";
diff --git a/src/Microsoft.ML.Core/Data/ModelSaveContext.cs b/src/Microsoft.ML.Core/Data/ModelSaveContext.cs
@@ -21,18 +21,21 @@ public sealed partial class ModelSaveContext : IDisposable
         /// When in repository mode, this is the repository we're writing to. It is null when
         /// in single-stream mode.
         /// </summary>
-        public readonly RepositoryWriter Repository;
+        [BestFriend]
+        internal readonly RepositoryWriter Repository;
 
         /// <summary>
         /// When in repository mode, this is the directory we're reading from. Null means the root
         /// of the repository. It is always null in single-stream mode.
         /// </summary>
-        public readonly string Directory;
+        [BestFriend]
+        internal readonly string Directory;
 
         /// <summary>
         /// The main stream writer.
         /// </summary>
-        public readonly BinaryWriter Writer;
+        [BestFriend]
+        internal readonly BinaryWriter Writer;
 
         /// <summary>
         /// The strings that will be saved in the main stream's string table.
@@ -49,7 +52,8 @@ public sealed partial class ModelSaveContext : IDisposable
         /// <summary>
         /// The min file position of the main stream.
         /// </summary>
-        public readonly long FpMin;
+        [BestFriend]
+        internal readonly long FpMin;
 
         /// <summary>
         /// The wrapped entry.
@@ -69,7 +73,8 @@ public sealed partial class ModelSaveContext : IDisposable
         /// <summary>
         /// Returns whether this context is in repository mode (true) or single-stream mode (false).
         /// </summary>
-        public bool InRepository { get { return Repository != null; } }
+        [BestFriend]
+        internal bool InRepository => Repository != null;
 
         /// <summary>
         /// Create a <see cref="ModelSaveContext"/> supporting saving to a repository, for implementors of <see cref="ICanSaveModel"/>.
@@ -125,7 +130,8 @@ internal ModelSaveContext(BinaryWriter writer, IExceptionContext ectx = null)
             ModelHeader.BeginWrite(Writer, out FpMin, out Header);
         }
 
-        public void CheckAtModel()
+        [BestFriend]
+        internal void CheckAtModel()
         {
             _ectx.Check(Writer.BaseStream.Position == FpMin + Header.FpModel);
         }
@@ -135,13 +141,15 @@ public void CheckAtModel()
         /// <see cref="Done"/> is called.
         /// </summary>
         /// <param name="ver"></param>
-        public void SetVersionInfo(VersionInfo ver)
+        [BestFriend]
+        internal void SetVersionInfo(VersionInfo ver)
         {
             ModelHeader.SetVersionInfo(ref Header, ver);
             _loaderAssemblyName = ver.LoaderAssemblyName;
         }
 
-        public void SaveTextStream(string name, Action<TextWriter> action)
+        [BestFriend]
+        internal void SaveTextStream(string name, Action<TextWriter> action)
         {
             _ectx.Check(InRepository, "Can't save a text stream when writing to a single stream");
             _ectx.CheckNonEmpty(name, nameof(name));
@@ -156,7 +164,8 @@ public void SaveTextStream(string name, Action<TextWriter> action)
             }
         }
 
-        public void SaveBinaryStream(string name, Action<BinaryWriter> action)
+        [BestFriend]
+        internal void SaveBinaryStream(string name, Action<BinaryWriter> action)
         {
             _ectx.Check(InRepository, "Can't save a text stream when writing to a single stream");
             _ectx.CheckNonEmpty(name, nameof(name));
@@ -175,7 +184,8 @@ public void SaveBinaryStream(string name, Action<BinaryWriter> action)
         /// Puts a string into the context pool, and writes the integer code of the string ID
         /// to the write stream. If str is null, this writes -1 and doesn't add it to the pool.
         /// </summary>
-        public void SaveStringOrNull(string str)
+        [BestFriend]
+        internal void SaveStringOrNull(string str)
         {
             if (str == null)
                 Writer.Write(-1);
@@ -187,13 +197,15 @@ public void SaveStringOrNull(string str)
         /// Puts a string into the context pool, and writes the integer code of the string ID
         /// to the write stream. Checks that str is not null.
         /// </summary>
-        public void SaveString(string str)
+        [BestFriend]
+        internal void SaveString(string str)
         {
             _ectx.CheckValue(str, nameof(str));
             Writer.Write(Strings.Add(str).Id);
         }
 
-        public void SaveString(ReadOnlyMemory<char> str)
+        [BestFriend]
+        internal void SaveString(ReadOnlyMemory<char> str)
         {
             Writer.Write(Strings.Add(str).Id);
         }
@@ -202,13 +214,15 @@ public void SaveString(ReadOnlyMemory<char> str)
         /// Puts a string into the context pool, and writes the integer code of the string ID
         /// to the write stream.
         /// </summary>
-        public void SaveNonEmptyString(string str)
+        [BestFriend]
+        internal void SaveNonEmptyString(string str)
         {
             _ectx.CheckParam(!string.IsNullOrEmpty(str), nameof(str));
             Writer.Write(Strings.Add(str).Id);
         }
 
-        public void SaveNonEmptyString(ReadOnlyMemory<Char> str)
+        [BestFriend]
+        internal void SaveNonEmptyString(ReadOnlyMemory<char> str)
         {
             Writer.Write(Strings.Add(str).Id);
         }
@@ -217,7 +231,8 @@ public void SaveNonEmptyString(ReadOnlyMemory<Char> str)
         /// Commit the save operation. This completes writing of the main stream. When in repository
         /// mode, it disposes <see cref="Writer"/> (but not <see cref="Repository"/>).
         /// </summary>
-        public void Done()
+        [BestFriend]
+        internal void Done()
         {
             _ectx.Check(Header.ModelSignature != 0, "ModelSignature not specified!");
             ModelHeader.EndWrite(Writer, FpMin, ref Header, Strings, _loaderAssemblyName);
diff --git a/src/Microsoft.ML.Core/Data/ModelSaving.cs b/src/Microsoft.ML.Core/Data/ModelSaving.cs
@@ -11,9 +11,10 @@ namespace Microsoft.ML.Model
     public sealed partial class ModelSaveContext : IDisposable
     {
         /// <summary>
-        /// Save a sub model to the given sub directory. This requires InRepository to be true.
+        /// Save a sub model to the given sub directory. This requires <see cref="InRepository"/> to be <see langword="true"/>.
         /// </summary>
-        public void SaveModel<T>(T value, string name)
+        [BestFriend]
+        internal void SaveModel<T>(T value, string name)
             where T : class
         {
             _ectx.Check(InRepository, "Can't save a sub-model when writing to a single stream");
@@ -23,7 +24,8 @@ public void SaveModel<T>(T value, string name)
         /// <summary>
         /// Save the object by calling TrySaveModel then falling back to .net serialization.
         /// </summary>
-        public static void SaveModel<T>(RepositoryWriter rep, T value, string path)
+        [BestFriend]
+        internal static void SaveModel<T>(RepositoryWriter rep, T value, string path)
             where T : class
         {
             if (value == null)
@@ -55,7 +57,8 @@ public static void SaveModel<T>(RepositoryWriter rep, T value, string path)
         /// <summary>
         /// Save to a single-stream by invoking the given action.
         /// </summary>
-        public static void Save(BinaryWriter writer, Action<ModelSaveContext> fn)
+        [BestFriend]
+        internal static void Save(BinaryWriter writer, Action<ModelSaveContext> fn)
         {
             Contracts.CheckValue(writer, nameof(writer));
             Contracts.CheckValue(fn, nameof(fn));
@@ -68,9 +71,11 @@ public static void Save(BinaryWriter writer, Action<ModelSaveContext> fn)
         }
 
         /// <summary>
-        /// Save to the given sub directory by invoking the given action. This requires InRepository to be true.
+        /// Save to the given sub directory by invoking the given action. This requires
+        /// <see cref="InRepository"/> to be <see langword="true"/>.
         /// </summary>
-        public void SaveSubModel(string dir, Action<ModelSaveContext> fn)
+        [BestFriend]
+        internal void SaveSubModel(string dir, Action<ModelSaveContext> fn)
         {
             _ectx.Check(InRepository, "Can't save a sub-model when writing to a single stream");
             _ectx.CheckNonEmpty(dir, nameof(dir));
diff --git a/src/Microsoft.ML.Core/Data/Repository.cs b/src/Microsoft.ML.Core/Data/Repository.cs
@@ -32,9 +32,10 @@ internal interface ICanSaveInBinaryFormat
     }
 
     /// <summary>
-    /// Abstraction around a ZipArchive or other hierarchical storage.
+    /// Abstraction around a <see cref="ZipArchive"/> or other hierarchical storage.
     /// </summary>
-    public abstract class Repository : IDisposable
+    [BestFriend]
+    internal abstract class Repository : IDisposable
     {
         public sealed class Entry : IDisposable
         {
@@ -289,7 +290,8 @@ protected Entry AddEntry(string pathEnt, Stream stream)
         }
     }
 
-    public sealed class RepositoryWriter : Repository
+    [BestFriend]
+    internal sealed class RepositoryWriter : Repository
     {
         private const string DirTrainingInfo = "TrainingInfo";
 
@@ -429,7 +431,8 @@ public void Commit()
         }
     }
 
-    public sealed class RepositoryReader : Repository
+    [BestFriend]
+    internal sealed class RepositoryReader : Repository
     {
         private ZipArchive _archive;
 
diff --git a/src/Microsoft.ML.Data/DataLoadSave/TransformWrapper.cs b/src/Microsoft.ML.Data/DataLoadSave/TransformWrapper.cs
@@ -87,7 +87,7 @@ private static VersionInfo GetVersionInfo()
         }
 
         // Factory for SignatureLoadModel.
-        public TransformWrapper(IHostEnvironment env, ModelLoadContext ctx)
+        private TransformWrapper(IHostEnvironment env, ModelLoadContext ctx)
         {
             Contracts.CheckValue(env, nameof(env));
             _host = env.Register(nameof(TransformWrapper));
diff --git a/src/Microsoft.ML.Data/DataLoadSave/TransformerChain.cs b/src/Microsoft.ML.Data/DataLoadSave/TransformerChain.cs
@@ -239,7 +239,7 @@ public static class TransformerChain
     {
         public const string LoaderSignature = "TransformerChain";
 
-        public static TransformerChain<ITransformer> Create(IHostEnvironment env, ModelLoadContext ctx)
+        private static TransformerChain<ITransformer> Create(IHostEnvironment env, ModelLoadContext ctx)
             => new TransformerChain<ITransformer>(env, ctx);
 
         /// <summary>
diff --git a/src/Microsoft.ML.Data/Dirty/ModelParametersBase.cs b/src/Microsoft.ML.Data/Dirty/ModelParametersBase.cs
@@ -14,20 +14,23 @@ namespace Microsoft.ML.Internal.Internallearn
     /// </summary>
     public abstract class ModelParametersBase<TOutput> : ICanSaveModel, IPredictorProducing<TOutput>
     {
-        public const string NormalizerWarningFormat =
+        private const string NormalizerWarningFormat =
             "Ignoring integrated normalizer while loading a predictor of type {0}.{1}" +
             "   Please refer to https://aka.ms/MLNetIssue for assistance with converting legacy models.";
 
-        protected readonly IHost Host;
+        [BestFriend]
+        private protected readonly IHost Host;
 
-        protected ModelParametersBase(IHostEnvironment env, string name)
+        [BestFriend]
+        private protected ModelParametersBase(IHostEnvironment env, string name)
         {
             Contracts.CheckValue(env, nameof(env));
             env.CheckNonWhiteSpace(name, nameof(name));
             Host = env.Register(name);
         }
 
-        protected ModelParametersBase(IHostEnvironment env, string name, ModelLoadContext ctx)
+        [BestFriend]
+        private protected ModelParametersBase(IHostEnvironment env, string name, ModelLoadContext ctx)
         {
             Contracts.CheckValue(env, nameof(env));
             env.CheckNonWhiteSpace(name, nameof(name));
diff --git a/src/Microsoft.ML.Data/Evaluators/MultiClassClassifierEvaluator.cs b/src/Microsoft.ML.Data/Evaluators/MultiClassClassifierEvaluator.cs
@@ -998,7 +998,7 @@ private protected override IEnumerable<string> GetPerInstanceColumnsToSave(RoleM
         // Multi-class evaluator adds four per-instance columns: "Assigned", "Top scores", "Top classes" and "Log-loss".
         private protected override IDataView GetPerInstanceMetricsCore(IDataView perInst, RoleMappedSchema schema)
         {
-            // If the label column is a key without text key values, convert it to I8, just for saving the per-instance
+            // If the label column is a key without text key values, convert it to double, just for saving the per-instance
             // text file, since if there are different key counts the columns cannot be appended.
             string labelName = schema.Label.Value.Name;
             if (!perInst.Schema.TryGetColumnIndex(labelName, out int labelColIndex))
diff --git a/src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs b/src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs
@@ -153,15 +153,15 @@ public abstract class CalibratorTransformer<TICalibrator> : RowToRowTransformerB
         private TICalibrator _calibrator;
         private readonly string _loaderSignature;
 
-        internal CalibratorTransformer(IHostEnvironment env, TICalibrator calibrator, string loaderSignature)
+        private protected CalibratorTransformer(IHostEnvironment env, TICalibrator calibrator, string loaderSignature)
             : base(Contracts.CheckRef(env, nameof(env)).Register(nameof(CalibratorTransformer<TICalibrator>)))
         {
             _loaderSignature = loaderSignature;
             _calibrator = calibrator;
         }
 
         // Factory method for SignatureLoadModel.
-        internal CalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx, string loaderSignature)
+        private protected CalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx, string loaderSignature)
             : base(Contracts.CheckRef(env, nameof(env)).Register(nameof(CalibratorTransformer<TICalibrator>)))
         {
             Contracts.AssertValue(ctx);
@@ -195,7 +195,7 @@ private protected override void SaveModel(ModelSaveContext ctx)
 
         private protected override IRowMapper MakeRowMapper(DataViewSchema schema) => new Mapper<TICalibrator>(this, _calibrator, schema);
 
-        protected VersionInfo GetVersionInfo()
+        private protected VersionInfo GetVersionInfo()
         {
             return new VersionInfo(
                 modelSignature: "CALTRANS",
diff --git a/src/Microsoft.ML.Data/Transforms/InvertHashUtils.cs b/src/Microsoft.ML.Data/Transforms/InvertHashUtils.cs
@@ -321,7 +321,8 @@ public void Add(uint hash, T key)
     /// Simple utility class for saving a <see cref="VBuffer{T}"/> of ReadOnlyMemory
     /// as a model, both in a binary and more easily human readable form.
     /// </summary>
-    public static class TextModelHelper
+    [BestFriend]
+    internal static class TextModelHelper
     {
         private const string LoaderSignature = "TextSpanBuffer";
 
diff --git a/src/Microsoft.ML.Data/Transforms/OneToOneTransformerBase.cs b/src/Microsoft.ML.Data/Transforms/OneToOneTransformerBase.cs
@@ -32,7 +32,8 @@ protected OneToOneTransformerBase(IHost host, params (string outputColumnName, s
             ColumnPairs = columns;
         }
 
-        protected OneToOneTransformerBase(IHost host, ModelLoadContext ctx) : base(host)
+        [BestFriend]
+        private protected OneToOneTransformerBase(IHost host, ModelLoadContext ctx) : base(host)
         {
             // *** Binary format ***
             // int: number of added columns
diff --git a/src/Microsoft.ML.Data/Transforms/ValueMapping.cs b/src/Microsoft.ML.Data/Transforms/ValueMapping.cs
@@ -666,7 +666,7 @@ private static bool CheckModelVersion(ModelLoadContext ctx, VersionInfo versionI
             }
         }
 
-        protected static ValueMappingTransformer Create(IHostEnvironment env, ModelLoadContext ctx)
+        private protected static ValueMappingTransformer Create(IHostEnvironment env, ModelLoadContext ctx)
         {
             Contracts.CheckValue(env, nameof(env));
             env.CheckValue(ctx, nameof(ctx));
diff --git a/src/Microsoft.ML.StandardLearners/Standard/LinearModelParameters.cs b/src/Microsoft.ML.StandardLearners/Standard/LinearModelParameters.cs
@@ -131,7 +131,7 @@ public LinearModelParameters(IHostEnvironment env, string name, in VBuffer<float
                 _weightsDenseLock = new object();
         }
 
-        protected LinearModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)
+        private protected LinearModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)
             : base(env, name, ctx)
         {
             // *** Binary format ***
@@ -547,12 +547,14 @@ private protected override void SaveAsIni(TextWriter writer, RoleMappedSchema sc
 
     public abstract class RegressionModelParameters : LinearModelParameters
     {
-        public RegressionModelParameters(IHostEnvironment env, string name, in VBuffer<float> weights, float bias)
+        [BestFriend]
+        private protected RegressionModelParameters(IHostEnvironment env, string name, in VBuffer<float> weights, float bias)
              : base(env, name, in weights, bias)
         {
         }
 
-        protected RegressionModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)
+        [BestFriend]
+        private protected RegressionModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)
             : base(env, name, ctx)
         {
         }
diff --git a/test/Microsoft.ML.CodeAnalyzer.Tests/Code/ContractsCheckTest.cs b/test/Microsoft.ML.CodeAnalyzer.Tests/Code/ContractsCheckTest.cs
@@ -39,9 +39,6 @@ public async Task ContractsCheck()
                 VerifyCS.Diagnostic(ContractsCheckAnalyzer.SimpleMessageDiagnostic.Rule).WithLocation(basis + 32, 35).WithArguments("Check", "\"Less fine: \" + env.GetType().Name"),
                 VerifyCS.Diagnostic(ContractsCheckAnalyzer.NameofDiagnostic.Rule).WithLocation(basis + 34, 17).WithArguments("CheckUserArg", "name", "\"p\""),
                 VerifyCS.Diagnostic(ContractsCheckAnalyzer.DecodeMessageWithLoadContextDiagnostic.Rule).WithLocation(basis + 39, 41).WithArguments("CheckDecode", "\"This message is suspicious\""),
-                new DiagnosticResult("CS0117", DiagnosticSeverity.Error).WithLocation("Test1.cs", 220, 70).WithMessage("'MessageSensitivity' does not contain a definition for 'UserData'"),
-                new DiagnosticResult("CS0117", DiagnosticSeverity.Error).WithLocation("Test1.cs", 231, 70).WithMessage("'MessageSensitivity' does not contain a definition for 'Schema'"),
-                new DiagnosticResult("CS1061", DiagnosticSeverity.Error).WithLocation("Test1.cs", 747, 21).WithMessage("'IHostEnvironment' does not contain a definition for 'IsCancelled' and no accessible extension method 'IsCancelled' accepting a first argument of type 'IHostEnvironment' could be found (are you missing a using directive or an assembly reference?)"),
             };
 
             var test = new VerifyCS.Test
diff --git a/test/Microsoft.ML.CodeAnalyzer.Tests/Resources/ContractsCheckResource.cs b/test/Microsoft.ML.CodeAnalyzer.Tests/Resources/ContractsCheckResource.cs

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ namespace Microsoft.ML.Model`
`16`	`16`	`[BestFriend]`
`17`	`17`	`internal delegate void SignatureLoadModel(ModelLoadContext ctx);`
`18`	`18`
`19`		`- public sealed partial class ModelLoadContext : IDisposable`
	`19`	`+ internal sealed partial class ModelLoadContext : IDisposable`
`20`	`20`	`{`
`21`	`21`	`public const string ModelStreamName = "Model.key";`
`22`	`22`	`internal const string NameBinary = "Model.bin";`
Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,10 @@ internal interface ICanSaveInBinaryFormat`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`/// <summary>`
`35`		`- /// Abstraction around a ZipArchive or other hierarchical storage.`
	`35`	`+ /// Abstraction around a <see cref="ZipArchive"/> or other hierarchical storage.`
`36`	`36`	`/// </summary>`
`37`		`- public abstract class Repository : IDisposable`
	`37`	`+ [BestFriend]`
	`38`	`+ internal abstract class Repository : IDisposable`
`38`	`39`	`{`
`39`	`40`	`public sealed class Entry : IDisposable`
`40`	`41`	`{`
`@@ -289,7 +290,8 @@ protected Entry AddEntry(string pathEnt, Stream stream)`
`289`	`290`	`}`
`290`	`291`	`}`
`291`	`292`
`292`		`- public sealed class RepositoryWriter : Repository`
	`293`	`+ [BestFriend]`
	`294`	`+ internal sealed class RepositoryWriter : Repository`
`293`	`295`	`{`
`294`	`296`	`private const string DirTrainingInfo = "TrainingInfo";`
`295`	`297`
`@@ -429,7 +431,8 @@ public void Commit()`
`429`	`431`	`}`
`430`	`432`	`}`
`431`	`433`
`432`		`- public sealed class RepositoryReader : Repository`
	`434`	`+ [BestFriend]`
	`435`	`+ internal sealed class RepositoryReader : Repository`
`433`	`436`	`{`
`434`	`437`	`private ZipArchive _archive;`
`435`	`438`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ private static VersionInfo GetVersionInfo()`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`// Factory for SignatureLoadModel.`
`90`		`- public TransformWrapper(IHostEnvironment env, ModelLoadContext ctx)`
	`90`	`+ private TransformWrapper(IHostEnvironment env, ModelLoadContext ctx)`
`91`	`91`	`{`
`92`	`92`	`Contracts.CheckValue(env, nameof(env));`
`93`	`93`	`_host = env.Register(nameof(TransformWrapper));`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public static class TransformerChain`
`239`	`239`	`{`
`240`	`240`	`public const string LoaderSignature = "TransformerChain";`
`241`	`241`
`242`		`- public static TransformerChain<ITransformer> Create(IHostEnvironment env, ModelLoadContext ctx)`
	`242`	`+ private static TransformerChain<ITransformer> Create(IHostEnvironment env, ModelLoadContext ctx)`
`243`	`243`	`=> new TransformerChain<ITransformer>(env, ctx);`
`244`	`244`
`245`	`245`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -998,7 +998,7 @@ private protected override IEnumerable<string> GetPerInstanceColumnsToSave(RoleM`
`998`	`998`	`// Multi-class evaluator adds four per-instance columns: "Assigned", "Top scores", "Top classes" and "Log-loss".`
`999`	`999`	`private protected override IDataView GetPerInstanceMetricsCore(IDataView perInst, RoleMappedSchema schema)`
`1000`	`1000`	`{`
`1001`		`- // If the label column is a key without text key values, convert it to I8, just for saving the per-instance`
	`1001`	`+ // If the label column is a key without text key values, convert it to double, just for saving the per-instance`
`1002`	`1002`	`// text file, since if there are different key counts the columns cannot be appended.`
`1003`	`1003`	`string labelName = schema.Label.Value.Name;`
`1004`	`1004`	`if (!perInst.Schema.TryGetColumnIndex(labelName, out int labelColIndex))`
Original file line number	Diff line number	Diff line change
`@@ -153,15 +153,15 @@ public abstract class CalibratorTransformer<TICalibrator> : RowToRowTransformerB`
`153`	`153`	`private TICalibrator _calibrator;`
`154`	`154`	`private readonly string _loaderSignature;`
`155`	`155`
`156`		`- internal CalibratorTransformer(IHostEnvironment env, TICalibrator calibrator, string loaderSignature)`
	`156`	`+ private protected CalibratorTransformer(IHostEnvironment env, TICalibrator calibrator, string loaderSignature)`
`157`	`157`	`: base(Contracts.CheckRef(env, nameof(env)).Register(nameof(CalibratorTransformer<TICalibrator>)))`
`158`	`158`	`{`
`159`	`159`	`_loaderSignature = loaderSignature;`
`160`	`160`	`_calibrator = calibrator;`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`// Factory method for SignatureLoadModel.`
`164`		`- internal CalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx, string loaderSignature)`
	`164`	`+ private protected CalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx, string loaderSignature)`
`165`	`165`	`: base(Contracts.CheckRef(env, nameof(env)).Register(nameof(CalibratorTransformer<TICalibrator>)))`
`166`	`166`	`{`
`167`	`167`	`Contracts.AssertValue(ctx);`
`@@ -195,7 +195,7 @@ private protected override void SaveModel(ModelSaveContext ctx)`
`195`	`195`
`196`	`196`	`private protected override IRowMapper MakeRowMapper(DataViewSchema schema) => new Mapper<TICalibrator>(this, _calibrator, schema);`
`197`	`197`
`198`		`- protected VersionInfo GetVersionInfo()`
	`198`	`+ private protected VersionInfo GetVersionInfo()`
`199`	`199`	`{`
`200`	`200`	`return new VersionInfo(`
`201`	`201`	`modelSignature: "CALTRANS",`
Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,8 @@ public void Add(uint hash, T key)`
`321`	`321`	`/// Simple utility class for saving a <see cref="VBuffer{T}"/> of ReadOnlyMemory`
`322`	`322`	`/// as a model, both in a binary and more easily human readable form.`
`323`	`323`	`/// </summary>`
`324`		`- public static class TextModelHelper`
	`324`	`+ [BestFriend]`
	`325`	`+ internal static class TextModelHelper`
`325`	`326`	`{`
`326`	`327`	`private const string LoaderSignature = "TextSpanBuffer";`
`327`	`328`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ protected OneToOneTransformerBase(IHost host, params (string outputColumnName, s`
`32`	`32`	`ColumnPairs = columns;`
`33`	`33`	`}`
`34`	`34`
`35`		`- protected OneToOneTransformerBase(IHost host, ModelLoadContext ctx) : base(host)`
	`35`	`+ [BestFriend]`
	`36`	`+ private protected OneToOneTransformerBase(IHost host, ModelLoadContext ctx) : base(host)`
`36`	`37`	`{`
`37`	`38`	`// * Binary format *`
`38`	`39`	`// int: number of added columns`
Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@ private static bool CheckModelVersion(ModelLoadContext ctx, VersionInfo versionI`
`666`	`666`	`}`
`667`	`667`	`}`
`668`	`668`
`669`		`- protected static ValueMappingTransformer Create(IHostEnvironment env, ModelLoadContext ctx)`
	`669`	`+ private protected static ValueMappingTransformer Create(IHostEnvironment env, ModelLoadContext ctx)`
`670`	`670`	`{`
`671`	`671`	`Contracts.CheckValue(env, nameof(env));`
`672`	`672`	`env.CheckValue(ctx, nameof(ctx));`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ public LinearModelParameters(IHostEnvironment env, string name, in VBuffer<float`
`131`	`131`	`_weightsDenseLock = new object();`
`132`	`132`	`}`
`133`	`133`
`134`		`- protected LinearModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)`
	`134`	`+ private protected LinearModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)`
`135`	`135`	`: base(env, name, ctx)`
`136`	`136`	`{`
`137`	`137`	`// * Binary format *`
`@@ -547,12 +547,14 @@ private protected override void SaveAsIni(TextWriter writer, RoleMappedSchema sc`
`547`	`547`
`548`	`548`	`public abstract class RegressionModelParameters : LinearModelParameters`
`549`	`549`	`{`
`550`		`- public RegressionModelParameters(IHostEnvironment env, string name, in VBuffer<float> weights, float bias)`
	`550`	`+ [BestFriend]`
	`551`	`+ private protected RegressionModelParameters(IHostEnvironment env, string name, in VBuffer<float> weights, float bias)`
`551`	`552`	`: base(env, name, in weights, bias)`
`552`	`553`	`{`
`553`	`554`	`}`
`554`	`555`
`555`		`- protected RegressionModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)`
	`556`	`+ [BestFriend]`
	`557`	`+ private protected RegressionModelParameters(IHostEnvironment env, string name, ModelLoadContext ctx)`
`556`	`558`	`: base(env, name, ctx)`
`557`	`559`	`{`
`558`	`560`	`}`