Rename types inside MLContext as Catalogs #2169
Conversation
| /// </summary> | ||
| /// <param name="ctx">The clustering context trainer object.</param> | ||
| /// <param name="catalog">The clustering catalog trainer object.</param> |
There was a problem hiding this comment.
catalog [](start = 25, length = 7)
Great, thanks for fixing these as well, I'd kind of forgotten that we'd want to change the parameter names and descriptors here... and there sure are a lot of them. ;)
| @@ -38,7 +38,7 @@ public void SdcaRegression() | |||
| var dataPath = GetDataPath(TestDatasets.generatedRegressionDataset.trainFilename); | |||
| var dataSource = new MultiFileSource(dataPath); | |||
|
|
|||
| var ctx = new RegressionContext(env); | |||
| var catalog = new RegressionCatalog(env); | |||
There was a problem hiding this comment.
new RegressionCatalog(env); [](start = 26, length = 27)
Hmmmm interesting. This guy is a bit of an odd duck, I guess it was done before we "unified" the contexts under MLContext. We'll probably want to bring these more up to date at some point lest they mislead people. (Not part of this PR, to be clear.)
There was a problem hiding this comment.
Cool thanks @najeeb-kazmi for changing the names, and all the references in those, probably, hundred plus places in the documentation and parameter names. 👍
|
advanced settings was removed from the API for Is there a simple way of specifying "unbalancedSets" as before? |
ghost
locked as resolved and limited conversation to collaborators
Fixes #1796
Renames
XyzContexttypes insideMLContexttoXyzCatalog.Renames
DataOperationstoDataOperationsCatalog.