[iOS] - Fix Custom FlyoutIcon from Being Overridden to Default Color in Shell #27580
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @prakashKannanSf3972! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
sheiksyedm
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Feb 12, 2025
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| public void EnsureCustomFlyoutIconColor() |
There was a problem hiding this comment.
Pending macOS snapshot. Already available in the latest build:
There was a problem hiding this comment.
Thank you for highlighting this! The Pending Snapshot has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The color of the custom FlyoutIcon in Shell resets to the default blue instead of retaining its original color.
RootCause
By default,
UIImageRenderingModeis set toAutomatic, allowing the rendering behavior to be determined based on the UI context. When a customFlyoutIconis applied, it does not retain its original color but instead adapts to the predefined tinting behavior, leading to unintended color changes.Description of Change
The image rendering mode is now set to
UIImageRenderingMode.AlwaysOriginal, ensuring that custom icons maintain their original colors without being altered by default rendering behavior.FlyoutIconis set, its color can still be modified usingShell.ForegroundColor.FlyoutIconis applied, it now preserves its original image color without automatic tinting.Shell.ForegroundColorshould be set accordingly to allow the color modification to be applied.Issues Fixed
Fixes #6738
Tested the behaviour in the following platforms
Output