Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] CV1 & CV2 - Support for RTL #27653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 9, 2025

Description

This PR hopefully fixes a bunch of legacy Xamarin bugs related to RTL in the Collection View

Issues Fixed

Fixes #27653
xamarin/Xamarin.Forms#12633
xamarin/Xamarin.Forms#14149
xamarin/Xamarin.Forms#13165
xamarin/Xamarin.Forms#8759
xamarin/Xamarin.Forms#8260

Before - CV 2 After - CV 2
cv2-before.mp4
cv2-after.mp4
Before - CV 1 After - CV 1
cv1-before.mp4
cv1-after.mp4

@MartyIX
Copy link
Contributor

MartyIX commented Feb 10, 2025

@kubaflo Are the videos in #27653 (comment) switched possibly? Looks like "Before" behaves better than "After". :)

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 10, 2025

@MartyIX yeah, thanks for letting me know:)

@kubaflo kubaflo force-pushed the support-for-rtl-cv1 branch from 9f02b26 to 45b33af Compare February 10, 2025 18:50
@kubaflo kubaflo changed the title [iOS] CV1 - Support for RTL [iOS] CV1 & CV2 - Support for RTL Feb 10, 2025
@kubaflo kubaflo requested a review from rmarinho February 10, 2025 18:56
@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 10, 2025

Hi! @rmarinho what do you think?

@github-actions github-actions bot force-pushed the support-for-rtl-cv1 branch from 507164d to 2b81de6 Compare February 12, 2025 23:50
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho added this to the .NET 9 SR5 milestone Feb 12, 2025
@rmarinho rmarinho self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants