-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] CV1 & CV2 - Support for RTL #27653
Open
kubaflo
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
kubaflo:support-for-rtl-cv1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+116
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kubaflo Are the videos in #27653 (comment) switched possibly? Looks like "Before" behaves better than "After". :) |
@MartyIX yeah, thanks for letting me know:) |
9f02b26
to
45b33af
Compare
Hi! @rmarinho what do you think? |
507164d
to
2b81de6
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-controls-collectionview
CollectionView, CarouselView, IndicatorView
community ✨
Community Contribution
platform/iOS 🍎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hopefully fixes a bunch of legacy Xamarin bugs related to RTL in the Collection View
Issues Fixed
Fixes #27653
xamarin/Xamarin.Forms#12633
xamarin/Xamarin.Forms#14149
xamarin/Xamarin.Forms#13165
xamarin/Xamarin.Forms#8759
xamarin/Xamarin.Forms#8260
cv2-before.mp4
cv2-after.mp4
cv1-before.mp4
cv1-after.mp4