Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments #27658

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Update comments #27658

merged 3 commits into from
Feb 11, 2025

Conversation

APoukar
Copy link
Contributor

@APoukar APoukar commented Feb 9, 2025

Description of Change

There were incorrect comments in Shell class for a few methods. Mostly the comments were just misplaced (above wrong methods), so I've moved them around and added one comment of my own for GetFlyoutBackdrop.

Issues Fixed

Fixes #

@APoukar APoukar requested a review from a team as a code owner February 9, 2025 21:45
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 9, 2025
Copy link
Contributor

Hey there @APoukar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@APoukar
Copy link
Contributor Author

APoukar commented Feb 9, 2025

@dotnet-policy-service agree

jsuarezruiz
jsuarezruiz previously approved these changes Feb 10, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis
jfversluis previously approved these changes Feb 10, 2025
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@jfversluis jfversluis added the area-docs Conceptual docs, API docs, Samples label Feb 10, 2025
@PureWeen PureWeen dismissed stale reviews from jfversluis and jsuarezruiz via 675e351 February 10, 2025 21:46
@PureWeen PureWeen added this to the .NET 9 SR5 milestone Feb 10, 2025
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thank you so much for this!

@jfversluis jfversluis merged commit e267f41 into dotnet:main Feb 11, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-docs Conceptual docs, API docs, Samples community ✨ Community Contribution t/housekeeping ♻︎
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants