Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock activations by GrainId #9259

Closed
wants to merge 1 commit into from
Closed

Conversation

ntovas
Copy link
Contributor

@ntovas ntovas commented Dec 3, 2024

This is more like a proposal and a request for comments, but I believe since we already know the GrainId there is no reason to lock all activations.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
Copy link
Member

We could use striped locks instead of a single lock, but per-grain locks is a bit much.
I'll close this PR, but if we can show that it's worthwhile, we could use striped locks. Wg, hash grainId to one of N locks, where N is a small number like 16 or maybe CPU count rounded up to a power of 2

@ReubenBond ReubenBond closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants