Add X509CertificateLoader SecurityDesign doc #112149
Open
+363
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
added
documentation
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
vcsjones
reviewed
Feb 5, 2025
src/libraries/System.Security.Cryptography/docs/X509CertificateLoader.SecurityDesign.md
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/docs/X509CertificateLoader.SecurityDesign.md
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/docs/X509CertificateLoader.SecurityDesign.md
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/docs/X509CertificateLoader.SecurityDesign.md
Show resolved
Hide resolved
| Password-based confidentiality also specifies the number of iterations to run for the chosen KDF. | ||
| Callers can limit the number of iterations for the KDF on a single encrypted SafeContents via the `IndividualKdfIterationLimit` property (which .NET 9 defaults to 300,000). | ||
| As there can be more than one password-based SafeContents, callers can limit the total number of iterations across all KDFs via the `TotalKdfIterationLimit` property (which .NET 9 defaults to 1,000,000). | ||
| The `TotalKdfIterationLimit` property is also shared with ShroudedKeyBag entries, there are not separate controls for totals for SafeContents vs ShroudedKeyBags. If either the `IndividualKdfIterationLimit` or the `TotalKdfIterationLimit` would be exceeded when decrypting a SafeContents value, an exception is thrown BEFORE doing the work associated with the limit. |
There was a problem hiding this comment.
It may be worth noting that some work might be done before limits are exceeded. We generally cannot guarantee all of the KDF work is known up-front. A ShroudedKeyBag inside an encrypted AuthSafe means we need to do work to decrypt the authsafe before we know the work involved with the encrypted key bags.
There was a problem hiding this comment.
If you have some suggestion as to how to word that in, I'm happy to take it. To me, it's obvious by "would be exceeded when decrypting", indicating that it is evaluated at each individual decryption operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.