-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CalculateAssemblyAction
virtual.
#112154
Merged
sbomer
merged 1 commit into
dotnet:main
from
Unity-Technologies:linker-expose-calc-asm-action
Feb 5, 2025
Merged
Make CalculateAssemblyAction
virtual.
#112154
sbomer
merged 1 commit into
dotnet:main
from
Unity-Technologies:linker-expose-calc-asm-action
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to override this in UnityLinker
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
.NET linker development as well as trimming analyzers
label
Feb 4, 2025
dotnet-policy-service
bot
added
linkable-framework
Issues associated with delivering a linker friendly framework
community-contribution
Indicates that the PR has been added by a community member
labels
Feb 4, 2025
Tagging subscribers to this area: @dotnet/illink |
Not sure who's in charge of merging changes these days. Pinging you @sbomer in case @marek-safar isn't checking on PRs. |
sbomer
approved these changes
Feb 4, 2025
@sbomer I don't think the failures are related to this change. How do I get the PR merged? |
/ba-g "Unrelated timeouts" |
mrvoorhe
added a commit
to Unity-Technologies/runtime
that referenced
this pull request
Feb 6, 2025
We need to override this in UnityLinker
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 6, 2025
* main: (23 commits) add important remarks to NrbfDecoder (dotnet#111286) docs: fix spelling grammar and missing words in clr-code-guide.md (dotnet#112222) Consider type declaration order in MethodImpls (dotnet#111998) Add a feature flag to not use GVM in Linq Select (dotnet#109978) [cDAC] Implement ISOSDacInterface::GetMethodDescPtrFromIp (dotnet#110755) Restructure JSImport/JSExport generators to share more code and utilize more Microsoft.Interop.SourceGeneration shared code (dotnet#107769) Add more detailed explanations to control-flow RegexOpcode values (dotnet#112170) Add repo-specific condition to labeling workflows (dotnet#112169) Fix bad assembly when a nested exported type is marked via link.xml (dotnet#107945) Make `CalculateAssemblyAction` virtual. (dotnet#112154) JIT: Enable reusing profile-aware DFS trees between phases (dotnet#112198) Add support for LDAPTLS_CACERTDIR \ TrustedCertificateDirectory (dotnet#111877) JIT: Support custom `ClassLayout` instances with GC pointers in them (dotnet#112064) Factor positive lookaheads better into find optimizations (dotnet#112107) Add ImmutableCollectionsMarshal.AsMemory (dotnet#112177) [mono] ILStrip write directly to the output filestream (dotnet#112142) Allow the NativeAOT runtime pack to be specified as the ILC runtime package (dotnet#111876) JIT: some reworking for conditional escape analysis (dotnet#112194) Replace HELPER_METHOD_FRAME with DynamicHelperFrame in patchpoints (dotnet#112025) [Android] Decouple runtime initialization and entry point execution for Android sample (dotnet#111742) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Tools-ILLink
.NET linker development as well as trimming analyzers
community-contribution
Indicates that the PR has been added by a community member
linkable-framework
Issues associated with delivering a linker friendly framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to override this in UnityLinker