[browser] Leave the fingerprint pattern in relative path #112186
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered in dotnet/sdk#46233. We do hard fingerprinting on wasm generated assets during build. On disk the files already contain the fingerprint. During publish we upgrade those build assets to publish assets, so the item spec contains the fingerprint, but we want to treat the asset as "fingerprintable" for further processing during publish (eg. when generating import maps), so that there is still the link between unfingerprinted (eg.
dotnet.js) and fingerprinted (eg.dotnet.abcd.js) even though the file on disk exists only as fingerprinted.