Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Recompute test block weights after loop inversion #112197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanasifkhalid
Copy link
Member

Fixes #112196.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 5, 2025
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Member Author

Diffs show more churn than I expected. I'm seeing quite a few OSR methods where loop inversion changed flow into the OSR entry block, but profile consistency checks didn't flag anything because OSR blocks are excluded from analysis. We now seem to be getting it right in more cases; for example, in LinqBenchmarks:GroupBy00LinqMethodX(), we go from this:

BB19 [0023]  2       BB17,BB18           167.07 167 [039..03D)-> BB20(1)                 (always)                     i IBC hascall gcsafe bwd
BB20 [0004]  1       BB19                165.39 165 [03D..045)-> BB05(0.994),BB21(0.00595)   ( cond )                     i IBC bwd bwd-src osr-entry

to this:

BB19 [0023]  2       BB17,BB18           167.07 167 [039..03D)-> BB20(1)                 (always)                     i IBC hascall gcsafe bwd
BB20 [0004]  1       BB19                167.07 167 [03D..045)-> BB05(0.994),BB21(0.00595)   ( cond )                     i IBC bwd bwd-src osr-entry

@amanasifkhalid amanasifkhalid marked this pull request as ready for review February 5, 2025 20:02
@amanasifkhalid
Copy link
Member Author

amanasifkhalid commented Feb 5, 2025

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. libraries-pgo isn't hitting profile consistency asserts anymore. Looks like SPMI hit an infra issue on win-x64. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed '!"Inconsistent profile data"' in System.Text.Json.Tests with random GDV
1 participant