Backport XmlSerializer reflection changes to 8.0-staging #112320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null according to the xml.
StephenMolloy
added
the
Servicing-consider
This was referenced Feb 9, 2025
Open
mconnew
approved these changes
Feb 10, 2025
carlossanlop
removed
the
Servicing-consider
|
/ba-g The unknown build failure is a build timeout, unrelated to this change. |
carlossanlop
merged commit f6dd202
into
dotnet:release/8.0-staging
119 of 126 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111723 to release/8.0-staging
Customer Impact
Fixes #107252, #108432. A customer reported a couple of inconsistent behaviors between the usual ILGen-based XmlSerializer and the reflection-based XmlSerializer that they got switched over to because iOS projects don't support dynamic code by default. This PR addresses the null-vs-empty collections issue as well as the sub-types as collection items issue. A third issue regarding xml/type-mapping of hidden/overridden members that was included in the .Net 10 PR is not part of this backport since it touches code that the standard ILGen serializer also uses and we did not want to introduce any risk there.
Regression
Testing
Several tests were added to explore the reported scenarios exactly as well as some tangential exploration.
Risk
Low - These changes affect the reflection-based serializer only. We already know the reflection-based serializer is not yet up to parity with the ILGen serializer, but it is only used as a fallback in a minority of cases. The scenarios being changed here have had several tests added to explore potential impacts and ensure our changes are only doing what we intend.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.