Skip to content

[browser][coreCLR] fix incremental build #122798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavelsavara wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −159
Open

[browser][coreCLR] fix incremental build #122798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75ada40
remove browserhost sample
pavelsavara Dec 31, 2025
35a7419
fix incremental build
pavelsavara Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/workflow/building/coreclr/wasm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ cd ./artifacts/bin/coreclr/browser.wasm.Debug/corehost
node ./main.mjs
```

Note that paths to assemblies are in the `src/native/corehost/browserhost/sample/dotnet.boot.js`

## Debugging

### Chrome DevTools with DWARF Support
Expand Down
2 changes: 1 addition & 1 deletion eng/native/version/copy_version_files.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Get-ChildItem -Path "$VersionFolder" -Filter "_version.*" | ForEach-Object {
$current_contents = ""
$is_placeholder_file = $false
if (Test-Path -Path $version_file_destination) {
$current_contents = Get-Content -Path $version_file_destination -Raw
$current_contents = Get-Content -Path $version_file_destination
$is_placeholder_file = $current_contents -match "@\(#\)Version N/A @Commit:"
} else {
$is_placeholder_file = $true
Expand Down
3 changes: 2 additions & 1 deletion src/native/corehost/browserhost/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,5 @@ install(TARGETS browserhost DESTINATION sharedFramework COMPONENT runtime)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/dotnet.native.wasm DESTINATION corehost COMPONENT runtime)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/dotnet.native.wasm DESTINATION sharedFramework COMPONENT runtime)

add_subdirectory(sample)
set_source_files_properties(${BROWSERHOST_SOURCES} PROPERTIES OBJECT_DEPENDS
"${JS_SYSTEM_NATIVE_BROWSER};${JS_SYSTEM_BROWSER_UTILS};${JS_SYSTEM_RUNTIME_INTEROPSERVICES_JAVASCRIPT_NATIVE};${JS_BROWSER_HOST};${JS_SYSTEM_NATIVE_BROWSER_EXPOST}")
28 changes: 0 additions & 28 deletions src/native/corehost/browserhost/sample/CMakeLists.txt
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/native/corehost/browserhost/sample/HelloWorld.cs
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions src/native/corehost/browserhost/sample/HelloWorld.csproj
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/native/corehost/browserhost/sample/ReadMe.md
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions src/native/corehost/browserhost/sample/dotnet.boot.js
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions src/native/corehost/browserhost/sample/index.html
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/native/corehost/browserhost/sample/main.mjs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/native/libs/Common/JavaScript/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ set(ROLLUP_TS_SOURCES
"${CLR_SRC_NATIVE_DIR}/rollup.config.defines.js"
"${CLR_SRC_NATIVE_DIR}/rollup.config.plugins.js"
"${CLR_SRC_NATIVE_DIR}/corehost/browserhost/libBrowserHost.footer.js"
"${CLR_SRC_NATIVE_DIR}/corehost/browserhost/sample/dotnet.boot.js"
"${CLR_SRC_NATIVE_DIR}/libs/System.Native.Browser/libSystem.Native.Browser.Utils.footer.js"
"${CLR_SRC_NATIVE_DIR}/libs/System.Native.Browser/libSystem.Native.Browser.extpost.js"
"${CLR_SRC_NATIVE_DIR}/libs/System.Native.Browser/libSystem.Native.Browser.footer.js"
Expand Down
Loading