Disable the windows SDK automated references for c++ #28596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dsplaisted
approved these changes
Oct 20, 2022
|
I don't think our c++/cli tests are currently even enabled. I'm having a difficult time getting them to run or to manually test this. Any suggestions? |
|
They've been disabled for a long time (see #11008). I think you should be able to enable them locally and try running them in VS to get some projects that work. |
…T-disablewindowsdkforc++
Add a test for checking the default include windows SDK behavior for c++ cli
|
@dsplaisted I turned on the existing cppcl itests and added a new one. Want to review the new test? |
dsplaisted
approved these changes
Nov 17, 2022
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs
Outdated
Show resolved
Hide resolved
… how we set the target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with package references enabled in c++ projects, the windows references should not be included by default.
Fixes #26203