Skip to content

Fix stdout suppression in dotnet watch with --no-hot-reload #52836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix stdout suppression in dotnet watch with --no-hot-reload #52836

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63a619e
Initial plan
Copilot Feb 4, 2026
5041b88
Fix dotnet watch run --no-hot-reload suppressing stdout output
Copilot Feb 4, 2026
472d2c4
Add test to verify stdout is captured with --no-hot-reload
Copilot Feb 4, 2026
1d5da17
Revert formatting changes
Copilot Feb 5, 2026
9a927a0
Remove redundant test and unskip existing tests that verify stdout
Copilot Feb 5, 2026
ec1899c
Re-skip flaky tests and add simple test for stdout capture
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BuiltInTools/dotnet-watch/Watch/DotNetWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public static async Task WatchAsync(DotNetWatchContext context, CancellationToke
{
[EnvironmentVariables.Names.DotnetWatch] = "1",
[EnvironmentVariables.Names.DotnetWatchIteration] = (iteration + 1).ToString(CultureInfo.InvariantCulture),
}
},
OnOutput = line => context.ProcessOutputReporter.ReportOutput(line)
};

var browserRefreshServer = projectRootNode != null && HotReloadAppModel.InferFromProject(context, projectRootNode) is WebApplicationAppModel webAppModel
Expand Down
14 changes: 14 additions & 0 deletions test/dotnet-watch.Tests/Watch/NoDepsAppTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,19 @@ public async Task RestartProcessThatTerminatesAfterFileChange()
Assert.NotEqual(processIdentifier, processIdentifier2);
await App.AssertExiting(); // process should exit after run
}

[Fact]
public async Task CapturesStdOutWithNoHotReload()
{
var testAsset = TestAssets.CopyTestAsset(AppName)
.WithSource();

App.Start(testAsset, ["--no-hot-reload"]);

// Verify that stdout from the application is captured
await App.AssertOutputLineStartsWith("Started");
await App.AssertOutputLineStartsWith("Process identifier =");
await App.AssertExiting();
}
}
}
Loading