InMemoryFileSystem fixes for tests in dotnet sdk#9011
Open
nobowned wants to merge 6 commits intodotnet:release/9.0.3xxfrom
Open
InMemoryFileSystem fixes for tests in dotnet sdk#9011nobowned wants to merge 6 commits intodotnet:release/9.0.3xxfrom
nobowned wants to merge 6 commits intodotnet:release/9.0.3xxfrom
Conversation
nobowned
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When virtualziing the root, file paths come back from EnumerateFileSystemEntries without the "/" on Linux and Mac. The virtualization also has issues with net475 on Windows.
Solution
The solution is to change IsPathInCone to no longer do unnecessary checks and mangling of the original path.
Checks:
These changes are for the tests in dotnet/sdk#48879