Enhance dotnet.generateAssets command to accept skipPrompt parameter for asset generation #8510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for asset generation
WardenGnaw
reviewed
Aug 8, 2025
| @@ -53,8 +53,8 @@ export function registerDebugger( | |||
| ); | |||
|
|
|||
| context.subscriptions.push( | |||
| vscode.commands.registerCommand('dotnet.generateAssets', async (selectedIndex) => { | |||
There was a problem hiding this comment.
To future proof from additional options and just appending more and more parameters.
Suggested change
| vscode.commands.registerCommand('dotnet.generateAssets', async (selectedIndex) => { | |
| vscode.commands.registerCommand('dotnet.generateAssets', async (selectedIndex: number, options: { skipPrompt?: boolean } = {}) => { |
| if (getCSharpDevKit()) { | ||
| // If skipPrompt is true, proceed with generating assets without showing the dialog | ||
| if (skipPrompt) { |
There was a problem hiding this comment.
Suggested change
| if (skipPrompt) { | |
| if (options.skipPrompt) { |
| @@ -63,8 +63,13 @@ export function registerDebugger( | |||
| ); | |||
| } | |||
|
|
|||
| async function promptForDevKitDebugConfigurations(): Promise<boolean> { | |||
| async function promptForDevKitDebugConfigurations(skipPrompt: boolean = false): Promise<boolean> { | |||
There was a problem hiding this comment.
Update to use new object, and no need to use a default here.
Suggested change
| async function promptForDevKitDebugConfigurations(skipPrompt: boolean = false): Promise<boolean> { | |
| async function promptForDevKitDebugConfigurations(options: { skipPrompt?: boolean }): Promise<boolean> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #8414