Merge pull request #223 from aware70/fix-audio-codec-setup

Fix warning about missing default codecs on first run
dpaulat · Jun 8, 2024 · 9dfbac6 · 9dfbac6
2 parents 601a2ad + 8536bc5
commit 9dfbac6
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/scwx-qt/source/scwx/qt/ui/setup/audio_codec_page.cpp b/scwx-qt/source/scwx/qt/ui/setup/audio_codec_page.cpp
@@ -164,10 +164,9 @@ bool AudioCodecPage::IsRequired()
    auto         oggCodecs =
       oggFormat.supportedAudioCodecs(QMediaFormat::ConversionMode::Decode);
 
-   // Setup is required if codec errors are not ignored, and the default codecs
-   // are not supported
-   return (!ignoreCodecErrors &&
-           oggCodecs.contains(QMediaFormat::AudioCodec::Vorbis));
+   // Setup is required if codec errors are not ignored, and no Ogg support
+   // is found.
+   return (!ignoreCodecErrors && oggCodecs.empty());
 }
 
 } // namespace setup