bump network to 3.2.* and data-default to 0.8.* #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MangoIV could you take a look at this? |
|
I guess because HaskellNet's PR is not merged this is not really testing the new network at all. Do you think merging before that is merged and released makes sense / is required? |
Closed
|
True, but merging this will allow one less local override / nixpkgs jailbreak. So as long as you don't see any downsides I'd suggest going ahead 👍 |
|
Hmm okay, since I don’t expect a major version bump on HaskellNet for your PR, I’ll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partner PR for the same HaskellNet PR . There is a network 3.2.7 and data-default 0.8 published on hackage, they both compile cleanly on this repository. The module structure did not change enough to make this project not compile. I am bumping the version on both of them.
Supersedes #40