Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to cancel idle peer task #3810

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Feb 6, 2025

Description

Related Issue

Fix #3809

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner February 6, 2025 09:34
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.19%. Comparing base (e5f63a9) to head (04d1c45).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
client/daemon/daemon.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   34.22%   34.19%   -0.03%     
==========================================
  Files         337      337              
  Lines       38982    38986       +4     
==========================================
- Hits        13341    13333       -8     
- Misses      24802    24811       +9     
- Partials      839      842       +3     
Flag Coverage Δ
unittests 34.19% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/peerhost.go 42.21% <ø> (ø)
client/daemon/peer/peertask_conductor.go 52.04% <100.00%> (+0.11%) ⬆️
client/daemon/daemon.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@aobt aobt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 4607435 into main Feb 10, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feat/add-option-to-cancel-idle-peer-task branch February 10, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peerTaskConductor should be canceled with filetask
3 participants