Skip to content

Conversation

gleber
Copy link
Contributor

@gleber gleber commented Apr 28, 2025

I've tried adding type annotations to parser and I was getting

TypeError: 'ForwardDeclaration' object does not support item assignment

This PR fixes it by ignoring annotations, which is likely wrong. I'd be happy to improve the solution.

Copy link
Owner

@drhagen drhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I will accept it with minor changes.

@gleber gleber force-pushed the handle-types branch 2 times, most recently from 7ca8d08 to 2bfc51b Compare April 30, 2025 18:02
@gleber
Copy link
Contributor Author

gleber commented Apr 30, 2025

Suggestions applied. PTAL

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (94d7c9f) to head (af12132).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          809       811    +2     
  Branches        86        87    +1     
=========================================
+ Hits           809       811    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drhagen drhagen merged commit 2dd49f6 into drhagen:master May 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants