Add option to enable filter for scanlines

drhelius · Jan 24, 2025 · 6b0e216 · 6b0e216
1 parent 073362f
commit 6b0e216
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/platforms/shared/desktop/config.cpp b/platforms/shared/desktop/config.cpp
@@ -183,6 +183,7 @@ void config_read(void)
     config_video.mix_frames = read_bool("Video", "MixFrames", true);
     config_video.mix_frames_intensity = read_float("Video", "MixFramesIntensity", 0.60f);
     config_video.scanlines = read_bool("Video", "Scanlines", true);
+    config_video.scanlines_filter = read_bool("Video", "ScanlinesFilter", true);
     config_video.scanlines_intensity = read_float("Video", "ScanlinesIntensity", 0.10f);
 
     config_video.sync = read_bool("Video", "Sync", true);
@@ -302,6 +303,7 @@ void config_write(void)
     write_bool("Video", "MixFrames", config_video.mix_frames);
     write_float("Video", "MixFramesIntensity", config_video.mix_frames_intensity);
     write_bool("Video", "Scanlines", config_video.scanlines);
+    write_bool("Video", "ScanlinesFilter", config_video.scanlines_filter);
     write_float("Video", "ScanlinesIntensity", config_video.scanlines_intensity);
     write_bool("Video", "Sync", config_video.sync);
 

diff --git a/platforms/shared/desktop/config.h b/platforms/shared/desktop/config.h
@@ -72,6 +72,7 @@ struct config_Video
     bool mix_frames = true;
     float mix_frames_intensity = 0.60f;
     bool scanlines = true;
+    bool scanlines_filter = true;
     float scanlines_intensity = 0.10f;
     bool sync = true;
 };

diff --git a/platforms/shared/desktop/gui_menus.cpp b/platforms/shared/desktop/gui_menus.cpp
@@ -437,6 +437,7 @@ static void menu_video(void)
         if (ImGui::BeginMenu("Scanlines"))
         {
             ImGui::MenuItem("Enable Scanlines", "", &config_video.scanlines);
+            ImGui::MenuItem("Enable Scanlines Filter", "", &config_video.scanlines_filter);
             ImGui::SliderFloat("##scanlines", &config_video.scanlines_intensity, 0.0f, 1.0f, "Intensity = %.2f");
             ImGui::EndMenu();
         }

diff --git a/platforms/shared/desktop/renderer.cpp b/platforms/shared/desktop/renderer.cpp
@@ -324,8 +324,16 @@ static void update_emu_texture(void)
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
 
-    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
-    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    if (config_video.scanlines && config_video.scanlines_filter)
+    {
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+    }
+    else
+    {
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    }
 }
 
 static void render_quad(void)