-
Notifications
You must be signed in to change notification settings - Fork 46
Replace PrestissimoFileFetcher with Guzzle #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Its this error again
Composer builds the autloader, but only PSR-0/4 autoloads, not file based. |
Yeah I have a solution for this - where did I put it? One moment. |
The issue is that Composer does not load the |
Not a great solution: https://github.com/g1a/starter/blob/master/customize/Customizer.php#L22 |
Maybe we should defer the download operation until the autoloader has been build? |
It will work just fine if you include the Guzzle files that are needed; however, Guzzle could easily decide to chose to add more files to the include section or rename the files, etc., and these would not be breaking changes per SemVer. It would be really grand if Guzzle would just move these functions into static class methods, as that would work from Composer plugins. |
I have not tried just manually including the autoload.php file. I'm not sure if this would or would not cause problems with Composer. The stated reason that Composer does not include the include files from the autoloader for plugins is that they cannot know if any given include file is idempotent. That is not a concern for Guzzle. |
We should not pursue this longer. The fix in #88 is much smaller. |
I was not able to resolve the error logging in #73. Therefore i tried to re-implement the feature on Guzzle again.
We had Guzzle some time about, but remove it because of dependency issues.