Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1268: Error when store a big data to cache #1272

Conversation

rigoucr
Copy link

@rigoucr rigoucr commented Mar 24, 2022

ISSUE: #1268 Error when store a big data to cache.

This PR Fixes the schema cache issue when your schema reach out certain size.

  • Issue description: when your schema reach certain size the Parsed schema object ( DocumentNode) becomes unmanageable by the unserialize function, leading to not loading the right cached schema data .

How to do a basic a test:

  • Apply this patch https://github.com/drupal-graphql/graphql/pull/1272.patch
  • clear drupals cache ( drush cr )
  • load the graphql explorer page admin/config/graphql/servers/manage/[SERVER-ID]/explorer
  • It should load without any issues
  • Now reload the explorer page, it should keep working as expected.

rigoucr added 2 commits March 24, 2022 14:30
…t because when the schema reach out certain size it couse unserialization issues breaking the schema caching
@klausi klausi added the 4.x label Nov 12, 2023
@klausi
Copy link
Contributor

klausi commented Nov 12, 2023

Should be fixed by #1364, so I think we don't need this. Please test!

@klausi klausi closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants