-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imitation Dynamics and Regret Minimization models added to the repo #229
Imitation Dynamics and Regret Minimization models added to the repo #229
Conversation
This all looks like a good potential contribution. Nice work. Can you how imitation dynamics is a different algorithm than fictitious play? I'd like you to add some documentation.: In Also in The docs are currently failing because the formatting is not quite right. The format is checked using |
The test suite is still failing at
Check the |
Reformatted using black version 24.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in our call right now:
- Let's get the CI passing :)
- Also if you could move the modules to the learning dir that would be great.
The local tox has passed all the checks; I have also moved the functions under the learning folder. Thanks. |
Thanks for the contribution @sandeepvshenoy 👍 |
This PR has the following changes.
Modified File
game.py -> Modified the file to add two new function calls within the code regret_minimization and imitation_dynamics
New Files
The following new files are added to attach the above functions and their corresponding test files into the repo
src/nashpy/egt/imitation_dynamics.py
src/nashpy/algorithms/regret_minimization.py
tests/unit/test_regret_minimization.py
tests/unit/test_imitation_dynamics.py