Add GH Action (CI) #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions) to the beginning of main (after arg parsing check but before `gtk_init()`) to enable them to work even when an X display is not available. This is useful for CI checks, amongst other things.
…h them See https://github.com/jessp01/devilspie2/actions/runs/13228243351/job/36921857237#step:5:87 Should be reinstated once fixed.
Open
Add Lua to the build matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH action:
devilspie2is invoked with-v,-wand-lI've moved the invocation of
show_version()(and all othershow_.*version()functions) to the beginning of main (after arg parsing check but beforegtk_init()) to enable them to work even when an X display is not available.While I've encountered it in CI context, I believe it's a good change to make in general.
I've also added
gettextto the list of dependencies inINSTALL, as make fails without it (it requiresmsgfmt).Note that, at present, the code will not build with Clang 17 and 18, see log. These checks should be added once corrected.