Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "UTF8BOM" and "UTF8NoBOM" to the acceptable values for Encoding parameter. #59

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Fix incorrect parameters

d30f23c
Select commit
Loading
Failed to load commit list.
Open

Add "UTF8BOM" and "UTF8NoBOM" to the acceptable values for Encoding parameter. #59

Fix incorrect parameters
d30f23c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2024 in 0s

95% (target 70%)

View this Pull Request on Codecov

95% (target 70%)

Details

Codecov Report

Attention: Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95%. Comparing base (0d1d026) to head (d30f23c).

Files with missing lines Patch % Lines
...s/FileContentDsc.Common/FileContentDsc.Common.psm1 92% 3 Missing ⚠️
...ces/DSC_KeyValuePairFile/DSC_KeyValuePairFile.psm1 88% 2 Missing ⚠️
.../DSCResources/DSC_ReplaceText/DSC_ReplaceText.psm1 80% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #59   +/-   ##
==================================
- Coverage    95%   95%   -1%     
==================================
  Files         4     4           
  Lines       264   304   +40     
==================================
+ Hits        253   290   +37     
- Misses       11    14    +3
Files with missing lines Coverage Δ
...ces/DSC_KeyValuePairFile/DSC_KeyValuePairFile.psm1 95% <88%> (-2%) ⬇️
.../DSCResources/DSC_ReplaceText/DSC_ReplaceText.psm1 97% <80%> (+2%) ⬆️
...s/FileContentDsc.Common/FileContentDsc.Common.psm1 88% <92%> (+5%) ⬆️
View more details on Codecov