Add shape::, array_ref::, and array::bounds() #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps avoid the common mistake of creating an array from an existing argument's shape, inheriting the strides and possibly violating compile-time constraints. (e.g. creating a planar image from an interleaved image's shape).
dsharlet
approved these changes
Aug 5, 2024
|
How does this relate to #83? This looks similar to a suggestion I made there:
I haven't been that happy with anything along these lines, but after so many years we should just go with what you have here. |
|
This looks just like what you suggested. We also discussed this on Chat a while back and I think bounds() was the winner for this particular problem. If you don't have any objections then, I'll merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.