Removes array_ref::{operator==, operator!=} #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It costs O(n) and is easy to accidentally invoke when the caller really only cares about pointer and shape equality. For content equality, use nda::equals().
jiawen
commented
Jan 3, 2025
| NDARRAY_HOST_DEVICE split_iterator& operator++() { | ||
| return *this += 1; | ||
| } | ||
| NDARRAY_HOST_DEVICE split_iterator& operator++() { return *this += 1; } |
There was a problem hiding this comment.
.clang-format did this. Happy to revert.
jiawen
changed the title
dsharlet
reviewed
Jan 3, 2025
| }); | ||
| return result; | ||
| } | ||
| NDARRAY_HOST_DEVICE bool operator==(const array_ref& other) const { return !operator!=(other); } |
There was a problem hiding this comment.
Does this build? array::operator== uses this.
It looks like travis stopped working (again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It costs O(n) and is easy to accidentally invoke when the caller really only cares about pointer and shape equality.
For content equality, use nda::equals().