fix: Ensure list-item.checked is not set to undefined

dstoc · Oct 18, 2024 · c19a5e6 · c19a5e6
1 parent 929fab7
commit c19a5e6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/markdown/normalize.ts b/src/markdown/normalize.ts
@@ -137,6 +137,14 @@ export function normalizeTree(tree: MarkdownTree) {
     }
     // Collapse directly nested lists.
     if (node.type === 'list-item') {
+      // Ensure checked is not set, rather than set to undefined
+      // since it could serialize as null.
+      if (
+        node.checked === null ||
+        (node.checked === undefined && 'checked' in node)
+      ) {
+        node[viewModel].updateChecked(undefined);
+      }
       if (
         node[viewModel].firstChild?.type === 'list' &&
         node.children?.length === 1

diff --git a/src/markdown/view-model.ts b/src/markdown/view-model.ts
@@ -227,7 +227,12 @@ export class ViewModel {
       case 'list-item': {
         const oldChecked = this.self.checked;
         if (oldChecked === checked) return;
-        (this.self as {checked?: boolean}).checked = checked;
+        if (checked == undefined) {
+          delete (this.self as {checked?: boolean}).checked;
+        } else {
+          (this.self as {checked?: boolean}).checked = checked;
+        }
+
         this.signalMutation({
           type: 'check',
           node: this.self,