Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export TokenMarker #1589

Closed
wants to merge 1 commit into from
Closed

Export TokenMarker #1589

wants to merge 1 commit into from

Conversation

fredrik-hammar
Copy link

Fixes #1588: TokenMarker is unexported.

@fredrik-hammar
Export TokenMarker
9d34813 
Fixes dtolnay#1588: TokenMarker is unexported.
@fredrik-hammar fredrik-hammar force-pushed the 1588-TokenMarker-is-unexported branch from d2d4e30 to 9d34813 Compare February 14, 2024 19:37
dtolnay
dtolnay reviewed Mar 11, 2024
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I suggested an alternative in #1588. I'll close this for now, but please follow up there and we can reopen the PR as needed.

@dtolnay dtolnay closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TokenMarker is unexported
2 participants
@fredrik-hammar @dtolnay