Bump aws to v1.5#133
Merged
Merged
Conversation
`exists` setting matches current behavior -- actual credential must be found/exist for `CREATE SECRET` to succeed. `none` matches previous (v1.3.2) behavior, where no credential is required at `CREATE SECRET` time. fixes duckdb#108
also fix/update include httpfs path
… absent credentials (and fix duckdb#108) - `exists` setting matches current behavior -- credential must be found/exist for `CREATE SECRET` to succeed. - `none` matches previous (v1.3.2) behavior, where no credential is required at `CREATE SECRET` time.
copy httpfs minio scripts directly for integration testing
plus remove debugging code
support create secret `validation` via {`none`, `exists`} options, to allow absent credentials (and fix duckdb#108)
Profiles should be read out of the config file, not credentials file
Fix profile loading when passed an explicit profile
update submodules
Tmonster
reviewed
Jan 20, 2026
Tmonster
left a comment
Tmonster
left a comment
Member
There was a problem hiding this comment.
Thanks! I think if the duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@ points to v1.4.3 the windows errors will go away.
Contributor
Member
Member
|
Hi @nicornk, yes it should be able to unlock work on those issues |
Closed
Member
|
this also needs to bump the submodules otherwise the miniotests wont use the correct version of duckdb, see #135 |
update duckdb-httpfs repo commit source env variables generate data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumps vcpkg from
5e5d0e1cd7785623065e77eff011afdeec1a3574(November 2024?) to84bab45d415d22042bd0b9081aea57f362da3f35(December 2025) for theMiniotests.Fixes https://github.com/duckdblabs/duckdb-internal/issues/7167